server/proxy/tcpproxy: reuse addr in TCPProxy.Run #19198
Conversation
|
Hi @callthingsoff. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
"addr" is the result of net.JoinHostPort which supports IPv6 address. Rather than ranging "tp.Endpoints" again, it's better to reuse "addr" in the first loop to collect "eps". See etcd-io#7942 and etcd-io#7943 for context. Signed-off-by: Jes Cok <[email protected]>
callthingsoff
force-pushed
the
reuse_addr_in_TCPProxy_Run
branch
from
f0f7e1d to
88a1bc3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 18 files with indirect coverage changes @@ Coverage Diff @@
## main #19198 +/- ##
==========================================
+ Coverage 68.82% 68.85% +0.03%
==========================================
Files 420 420
Lines 35627 35626 -1
==========================================
+ Hits 24519 24530 +11
+ Misses 9688 9678 -10
+ Partials 1420 1418 -2 Continue to review full report in Codecov by Sentry.
|
|
/ok-to-test |
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, callthingsoff, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
"addr" is the result of net.JoinHostPort which supports IPv6 address.
Rather than ranging "tp.Endpoints" again, it's better to reuse "addr" in the first loop to collect "eps".
See #7942 and #7943 for context.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.